docs: remove unnecessary English from Context example#1455
Merged
lumirlumir merged 3 commits intoreactjs:mainfrom Feb 2, 2026
Merged
docs: remove unnecessary English from Context example#1455lumirlumir merged 3 commits intoreactjs:mainfrom
lumirlumir merged 3 commits intoreactjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant English instruction sentence from the Korean translation of the “Replace prop drilling with Context” challenge, keeping the content fully Korean as intended.
Changes:
- Deleted the leftover English explanation line in the Solution section for the Context challenge example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lumirlumir
requested changes
Feb 2, 2026
| @@ -1024,8 +1024,6 @@ li { | |||
|
|
|||
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. | |
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. |
영어 원문이 최신 버전이라, Context에서 .Provider를 제거해주시겠어요?
Contributor
Author
There was a problem hiding this comment.
확인하고 반영했습니다! 안내해주셔서 감사합니다
Size changesDetails📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context로 prop drilling 대체하기 챌린지 불필요한 영어 문장 제거
위와 같이 이미 한국어로 번역이 되었음에도, 영어 문장이 불필요하게 남아있어 제거하였습니다.
필수 확인 사항
textlint가이드Textlint Guide선택 확인 사항